Revise file/attachment exception handling#6949
Merged
labkey-nicka merged 1 commit intodevelopfrom Aug 20, 2025
Merged
Conversation
XingY
reviewed
Aug 20, 2025
| catch (ConvertHelper.FileConversionException e) | ||
| { | ||
| throw new ApiUsageException(e); | ||
| errors.add(new PropertyValidationError(e.getMessage(), pd.getName())); |
Contributor
There was a problem hiding this comment.
Would this result in inconsistent error msg for FileLink? Can we just do errors.add(e.gerMessage())?
Contributor
Author
There was a problem hiding this comment.
I looked into the exact place and its trivial to handle in a similar manner BUT it causes the exception chaining that we're trying to avoid with those ApiUsageException opt-outs. I'm going to investigate a better way so we could do this.
In the meantime, I plan on merging these changes as-is assuming test runs look good.
XingY
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This addresses several test failures due to changes in #6941 which resulted in different, albeit desired, conversion exception handling of file/attachment fields.
Related Pull Requests
Changes
AttachmentDataIteratorto give more informative error in non-string value case.BatchValidationExceptionhandling when creating a run 😿.